New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map for ErrTxInMap in ostracon #810

Closed

4 tasks

Mdaiki0730 opened this issue Nov 28, 2022 · 0 comments · Fixed by #890

Closed

4 tasks

Map for ErrTxInMap in ostracon #810

Mdaiki0730 opened this issue Nov 28, 2022 · 0 comments · Fixed by #890

Assignees

Labels

Member

Mdaiki0730 commented Nov 28, 2022 •

edited

Loading

Summary

lbm-sdk needs to be mapped for new errors in ostracon.
https://github.com/line/ostracon/blob/v1.0.7/mempool/errors.go#L10

Problem Definition

New error, ErrInMap defined in ostracon.
For this error, lbm-sdk maps errors in types/errors/errors.go to make it easier for users to handle.

Proposal

I recommend adding errors to types/errors/errors.go and mapping them like client/broadcast.go.CheckTendermintError.

For Admin Use

Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned

Mdaiki0730 added the A: improvement label

Mdaiki0730 self-assigned this

Mdaiki0730 mentioned this issue

Map Ostracon:ErrTxInMap to lbm-sdk:ErrTxInMempoolCache #890

Merged

5 tasks

Mdaiki0730 closed this as completed in #890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment