Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation of Multi-thread Writing changes #583

Closed
4 tasks done
torao opened this issue Jul 5, 2022 · 1 comment
Closed
4 tasks done

Evaluation of Multi-thread Writing changes #583

torao opened this issue Jul 5, 2022 · 1 comment

Comments

@torao
Copy link
Contributor

torao commented Jul 5, 2022

Summary

Reconsideration of the effect of writing by multi-thread.

  • Report on the differences between current lbm-sdk and cosmos-sdk.
    • Aim of the change to lbm-sdk style implementation.
    • The actual effect of the lbm-sdk style implementation.
    • Consideration of the impact of this change on future cosmos-sdk merge task (e.g., how many changes are needed).
  • Decision whether to keep the lbm-sdk implementation or revert to the cosmos-sdk implementation.
  • If revert to a cosmos-sdk implementation, plan and progress of completing that work.

This task is to sort out useful features in order to reduce the differences between lbm-sdk and cosmos-sdk.

Parent: #549


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@torao
Copy link
Contributor Author

torao commented Jul 7, 2022

I made this title a separate issue because the approach for performance was different from that of Caching and Prefetching, but the only relevant code is only the following:
https://github.com/line/lbm-sdk/blob/2e12c78c0aa6f9a3f38407a4020fe331af5f367a/store/cachemulti/store.go#L141-L161

Also, the origin of this change has been added with the commit for Prefetching: c3e3f47#diff-3726a67741e4ddab06683dd6e86fe5f23be2237c6c766124e32db098af8e9e74R114-R122

The work is ineffective to investigate only this small issue, and also it seems unlikely to cause conflicts with the cosmos-sdk. For this reason, we'll delegate this issue to #582, and if we revert Prefetching, we'll revert this fix as well.

@torao torao closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant