Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check blockhash/txhash length whether it is 64 #58

Open
Tracked by #1
0Tech opened this issue Jan 11, 2024 · 3 comments
Open
Tracked by #1

chore: check blockhash/txhash length whether it is 64 #58

0Tech opened this issue Jan 11, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@0Tech
Copy link

0Tech commented Jan 11, 2024

No description provided.

@ulbqb ulbqb changed the title Triage finschia-sdk#699 chore: check blockhash/txhash length whether it is 64 Jan 22, 2024
@ulbqb
Copy link
Member

ulbqb commented Jan 22, 2024

@ulbqb
Copy link
Member

ulbqb commented Jan 30, 2024

Memo:
We should check if GetBlockByHash is needed.

Related PRs:
#32

@ulbqb
Copy link
Member

ulbqb commented Jan 31, 2024

https://github.com/Finschia/finschia-sdk/blob/v0.48.1/proto/lbm/base/ostracon/v1/query.proto
These all query is removed in current finschia-sdk. I think it should keep to be maintain even if ostracon is removed because of affection to outer applications.

@ulbqb ulbqb added enhancement New feature or request and removed needs-triage labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants