Segmentation Fault on Click

[FelixKratz]

It seems the bar will crash in some cases on a click event.
Due to the crash report by @MathewBlanc I know where this is happening, but It seems I am not able to reproduce this at the moment.

Originally posted by @MathewBlanc in https://github.com/FelixKratz/SketchyBar/discussions/218
Here's the crash report from Console:
sb_crashreport.txt

As for where it's happening, I have minimally modified the default config file:
sb_config.txt

[FelixKratz]

@MathewBlanc could you try the current master version? I think it should fix the segmentation fault. The curious thing is, that it should not be possible for the adid to be < 1 in the first place.

[MathewBlanc]

Forgive my ignorance, but how would I install the master version? I used homebrew to install it the first time

[FelixKratz]

You can install the current master version by:

brew services stop sketchybar
brew uninstall sketchybar
brew install sketchybar --head
brew services start sketchybar

and after testing you can switch back to the stable branch via:

brew services stop sketchybar
brew uninstall sketchybar
brew install sketchybar
brew services start sketchybar

Once this problem is resolved I will create a hotfix release.

[MathewBlanc]

Hi Felix, that seems to have fixed it, now I can click everywhere and nothing happens. Should I just stick with the master version for now?

Also, is there anything else you'd like me to test to get more info on the bug? 🙂

[FelixKratz]

I will create a new release once #220 is resolved and then you could switch back to the stable branch. Could you check if clicks on items that you have created a click_script for still work? Now that I know it is the adid that is causing the problem I can investigate the bug in more detail by tracing it through the code.

[MathewBlanc]

Yeah, I've put in your Simple Popup Menu and the click seems to work without any issues now 👍

[FelixKratz]

The new release is out, you can safely switch back to the stable branch.