Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blur_radius property to all items, brackets and popups #201

Closed
FelixKratz opened this issue Jun 15, 2022 · 7 comments
Closed

Add blur_radius property to all items, brackets and popups #201

FelixKratz opened this issue Jun 15, 2022 · 7 comments
Labels
Milestone

Comments

@FelixKratz
Copy link
Owner

FelixKratz commented Jun 15, 2022

With the new drawing logic in v2.7.0 it is possible to give each item a background blur, this could be used for nice blurred sections or to blur an image, e.g. a popup.background.image below other items or brackets.

Current implementation on master:
For item/bracket blur, e.g.:

sketchybar --set <name> blur_radius=50 background.drawing=on background.color=0x15000000

For popup blur, e.g.:

sketchybar --set <name> popup.blur_radius=50 popup.background.drawing=on popup.background.color=0x15000000
@FelixKratz FelixKratz added the enhancement New feature or request label Jun 15, 2022
FelixKratz added a commit that referenced this issue Jun 15, 2022
@FelixKratz
Copy link
Owner Author

This looks very nice, on the screenshot the blur is only half as strong as on screen.
Screen Shot 2022-06-16 at 00 41 35

@es183923
Copy link
Contributor

It doesn't seem possible to set a background blur for an item, but not the bar.

CleanShot 2022-06-15 at 22 17 43

@FelixKratz
Copy link
Owner Author

Works fine here, how do you set the blur? The background of the item must have a non-transparent color, otherwise the blur is not applied: e.g. background.color=0x15000000

@FelixKratz
Copy link
Owner Author

With c07737d the popups have a blur_radius property as well:
For item/bracket blur:

sketchybar --set <name> blur_radius=50 background.drawing=on background.color=0x15000000

For popup blur:

sketchybar --set <name> popup.blur_radius=50 popup.background.drawing=on popup.background.color=0x15000000

@es183923
Copy link
Contributor

Works fine here, how do you set the blur? The background of the item must have a non-transparent color, otherwise the blur is not applied: e.g. background.color=0x15000000

background.color is set as 0x30FFFFFF

@FelixKratz
Copy link
Owner Author

FelixKratz commented Jun 16, 2022

Can you try this snippet:

sketchybar --remove '/.*/' --bar color=0x00000000 blur_radius=0 --add item test left --set test icon=blur label=test background.color=0x15000000 blur_radius=50

This works perfectly fine on my end. I can not reproduce the problems with the blur here and I would need a minimal example to reproduce to further investigate.

Btw: your bar looks very nice and section blur would definitely be the final touch so lets get it working!

@es183923
Copy link
Contributor

Thanks! I got the blur radius working. I had put blur_radius in the --bar config, instead of under --default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants