Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test with java 23 #4851

Merged
merged 3 commits into from
Dec 12, 2024
Merged

CI: test with java 23 #4851

merged 3 commits into from
Dec 12, 2024

Conversation

pjfanning
Copy link
Member

Java 22 is not LTS and Java 23 is out. Java 23 contains a fix for #4848 so it is useful to know if this module works ok with Java 23.

@pjfanning
Copy link
Member Author

  • there are some test issues on Java 23
  • the main issue seems to be that mockito 4.11.0 doesn't seem to work in all cases on Java 23
    • mockito 5 needs newer Java version
    • might be able to fix the build so that it uses Mockito 5 for newer Java versions but 4.11.0 for Java 8
  • there may be 1 or 2 other test issues too

@pjfanning
Copy link
Member Author

#4856 is needed for this to work and possibly more changes too

@cowtowncoder
Copy link
Member

@pjfanning Thanks, merging other PRs and hopefully that is enough to make JDK 23 variant pass.

@cowtowncoder cowtowncoder merged commit 1143b67 into FasterXML:2.19 Dec 12, 2024
6 checks passed
@pjfanning pjfanning deleted the java23 branch December 12, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants