Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unknown opcodes print as decimal #6

Open
ktye opened this issue Jan 9, 2023 · 3 comments
Open

unknown opcodes print as decimal #6

ktye opened this issue Jan 9, 2023 · 3 comments

Comments

@ktye
Copy link

ktye commented Jan 9, 2023

memory.copy seems not to be implemented in the binary parser.
however the error message is:

unknown opcode sequence: 0xFC 0x10

which should be 0xFC 0x0A.
It looks like it's printed decimal in table.c (web49_bytes_to_opcode):

unknown opcode sequence: 0xFC 0x%" PRIu8

same for the other sequences.

@ShawSumma
Copy link
Member

thank you for the bug report, i was just working on implementing the rest of 0xFC....

@ShawSumma
Copy link
Member

I am doing a medium-sized refactor and this gets handled in there too.
I'll close the issue when web49 can handle all 0xFC opcodes.

@ktye
Copy link
Author

ktye commented Jan 17, 2023

you still have swapped the opcodes for (memory.copy memory.fill data.drop)
https://github.com/FastVM/Web49/blob/main/src/tables.c#L1456
it should be data.drop:0x09, memory.copy:0x0a, memory.fill:0x0b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants