New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods that return IEnumerable<T> should be consistent with yields #12

Open

FaronBracy opened this issue Feb 2, 2019 · 0 comments

Owner

FaronBracy commented Feb 2, 2019

DijkstraShortestPath.PathTo method returns an IEnumerable and could yield return DirectedEdge.
https://github.com/FaronBracy/RogueSharp/blob/master/RogueSharp/Algorithms/DijkstraShortestPath.cs#L130

Currently it does not, yet many other methods in the solution that return IEnumerable do.
https://github.com/FaronBracy/RogueSharp/blob/master/RogueSharp/Map.cs#L293

Investigate which approach is better and be consistent within the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment