Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DijkstraShortestPath Check method should be used or removed #11

Open
FaronBracy opened this issue Feb 2, 2019 · 0 comments
Open

DijkstraShortestPath Check method should be used or removed #11

FaronBracy opened this issue Feb 2, 2019 · 0 comments

Comments

@FaronBracy
Copy link
Owner

FaronBracy commented Feb 2, 2019

The DijkstraShortestPath class has a Check method that is currently only used by unit tests.
https://github.com/FaronBracy/RogueSharp/blob/master/RogueSharp/Algorithms/DijkstraShortestPath.cs#L153

It was originally intended to be a private method and called from the bottom of the constructor.

Investigate if this method is useful or not. If it's not get rid of it. If it is useful consider making it private and make the class use it where appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant