Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrated-to-typescript #361

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

migrated-to-typescript #361

wants to merge 7 commits into from

Conversation

ayush-129
Copy link
Contributor

@ayush-129 ayush-129 commented Oct 10, 2024 •
edited
Loading

Migrate to TypeScript and Next.js

fixes #117
The codes are migrated to typescript till now.
Please do give suggestions if any.
@Mr-Sunglasses

@netlify Netlify
Copy link

netlify bot commented Oct 10, 2024 •
edited
Loading

✅ Deploy Preview for fossc ready!

Name Link
🔨 Latest commit dfe8c9f
🔍 Latest deploy log https://app.netlify.com/sites/fossc/deploys/673d0059e470220009765489
😎 Deploy Preview https://deploy-preview-361--fossc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 68 (🔴 down 5 from production)
Accessibility: 89 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 95 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ayush-129
Copy link
Contributor Author

Locally it went everything well. Let me check once the deployment logs

@ayush-129
Copy link
Contributor Author

yeah, done its working fine now

@Mr-Sunglasses
Copy link
Member

Hey @ayush-129 Thanks a lot for PR, your work is amazing,.

Mr-Sunglasses
Mr-Sunglasses approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ayush-129

@Mr-Sunglasses
Copy link
Member

Mr-Sunglasses commented Nov 5, 2024 •
edited
Loading

@ayush-129 the only showstopper are the merge conflicts, can you fix them.

Mr-Sunglasses
Mr-Sunglasses requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few things that I think need to be changed

  • The homepage doesn't looks similar there are visual changes like animation alignment mismatched and a animation is present that should not be there

  • original ( fosscu.org )

Screenshot 2024-11-20 at 2 54 32 AM

Screenshot 2024-11-20 at 2 54 47 AM

  • current PR preview

Screenshot 2024-11-20 at 2 54 25 AM

Screenshot 2024-11-20 at 2 54 41 AM

  • The Nav bar is not identical, in this PR, a new Resouces is added which should not be there.

  • original ( fosscu.org )

Screenshot 2024-11-20 at 2 57 46 AM

  • current PR preview

Screenshot 2024-11-20 at 2 58 10 AM

  • One thing is that, why the ts -> js compile file is in the source code, I think they should be in the build ( ps. I don't know about this )

@YASH-YADAV-dynamo , @JiyaGupta-cs , @codecShivam , @adityaslyf PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Sunglasses Mr-Sunglasses Mr-Sunglasses requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to TypeScript and Next.js
2 participants
@ayush-129 @Mr-Sunglasses