Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message Class Names / paths on disk #585

Closed
ptheywood opened this issue Jul 7, 2021 · 1 comment · Fixed by #621
Closed

Message Class Names / paths on disk #585

ptheywood opened this issue Jul 7, 2021 · 1 comment · Fixed by #621
Milestone
New Features pre-...

Comments

@ptheywood
Copy link
Member

As of #551, messages classes are flamegpu::MsgNone, flamegpu::MsgBruteForce etc, however the header files are flamegpu/runtime/messaging/None.h, flamegpu/runtime/messaging/None/NoneHost.h etc.
This does not match.

Options:

  • Move these classes into a messaging namespace, and remove Msg from the class name.
    • Friendship related issues, but only the one. Swig might need some adjusting.
  • Change the file location on disk to match the class name , i.e. flamegpu/runtime/messaging/MsgNone.h and flamegpu/runtime/messaging/MsgNone/MsgNoneHost.h (or flamegpu/runtime/messaging/MsgNone/Host.h?)
  • Rename the classes and change the location on disk. Msg -> Message, there is no need to avoid verbosity.
@ptheywood ptheywood added this to the New Features pre-release? milestone Jul 15, 2021
@ptheywood
Copy link
Member Author

Rename classes and stuff on disk to MessageNone etc.

@ptheywood ptheywood mentioned this issue Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
New Features pre-release?
Development

Successfully merging a pull request may close this issue.

Rename Msg* classes to Message* FLAMEGPU/FLAMEGPU2
1 participant
@ptheywood