Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Membership trait changes to support PoS #3966

Open
5 tasks
pls148 opened this issue Dec 13, 2024 · 0 comments
Open
5 tasks

Membership trait changes to support PoS #3966

pls148 opened this issue Dec 13, 2024 · 0 comments
Assignees

Comments

@pls148
Copy link
Contributor

pls148 commented Dec 13, 2024

Reference meeting notes

  • HotShot clones the Membership object when receiving it, wrapping it in Arc<RwLock<>>
  • Remove requirement for Membership to implement Clone
  • Add sync_l1 and add_epoch_root functions, which return an Option<FnOnce(&mut Membership)> or similar. Functions should be called with a read lock held, then upgrade to write lock if a callback is returned. Default implementations should return None. A static helper function can be used to indicate if each function should be called at all.
  • Convert the existing Membership methods to async
  • Audit existing code to avoid Membership calls while holding other locks
@pls148 pls148 self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant