Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

barrier SEMANTICS const generic as bitflag #581

Closed
msiglreith opened this issue Apr 7, 2021 · 0 comments · Fixed by #598
Closed

barrier SEMANTICS const generic as bitflag #581

msiglreith opened this issue Apr 7, 2021 · 0 comments · Fixed by #598
Labels
t: bug Something isn't working

Comments

@msiglreith
Copy link
Contributor

The SEMANTICS used in control_barrier and memory_barrier is a bitflag, but currently only memory_barrier handles it as such. control_barrier only allows to set a single enum/flag.

https://github.com/EmbarkStudios/rust-gpu/blob/main/crates/spirv-std/src/arch/barrier.rs#L33-L36
https://github.com/EmbarkStudios/rust-gpu/blob/main/crates/spirv-std/src/arch/barrier.rs#L69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix semantics type for control barriers to support multiple flags msiglreith/rust-gpu
1 participant
@msiglreith