Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifact-path implementation #69

Open
clbx opened this issue Mar 16, 2023 · 2 comments
Open

artifact-path implementation #69

clbx opened this issue Mar 16, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@clbx
Copy link
Contributor

clbx commented Mar 16, 2023

Is your feature request related to a problem? Please describe.
The artifact-path argument in buildkite does not work since it runs on the agent, not the job.

Describe the solution you'd like
An argument for the plugin that replicates the features of the buildkite argument.

Additional context
Ive thought about when this could be done, the command could be appended to the end of any commands run in the pod, or it may be possible in a post-command step, but I'm not sure when this could be done.

I plan on opening a PR for this in the future when I get time, but I don't have the capacity right now.

@clbx clbx added the enhancement New feature or request label Mar 16, 2023
@tgolsson
Copy link
Member

The plugin runs in the container aswell but currently just fizzles; might be a good place to hook there? Should have access to all the configuration iirc.

if [[ -v "BUILDKITE_PLUGIN_K8S_IS_JOB" ]]; then
# do not recurse
exit 0
fi

@clbx
Copy link
Contributor Author

clbx commented Mar 16, 2023

Yeah I think that would be a good place to put it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants