Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

add .trim() to searchString #358

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

heysujal
Copy link
Contributor

Fixes Issue

Closes #356

Changes proposed

I have added trim() to searchString which removes the leading and trailing spaces which were earlier being taken into account as a part of actual query resulting in empty response.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Before

image

After

image

@heysujal
Copy link
Contributor Author

@Cahllagerfeld Please review.

Copy link
Member

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Cahllagerfeld Cahllagerfeld merged commit db3ab9d into EddieHubCommunity:main Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leading Empty spaces in query results in empty response in Search
2 participants