Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Convert sendResponse()s to Promises #18997

Closed
Hainish opened this issue Feb 29, 2020 · 3 comments
Closed

Convert sendResponse()s to Promises #18997

Hainish opened this issue Feb 29, 2020 · 3 comments
Assignees
@zoracon @pipboy96
Labels
code-style minor

Comments

@Hainish
Copy link
Member

Hainish commented Feb 29, 2020

Type: code issue

sendResponse() will be removed from the W3C spec, and returning a Promise from the onMessage handler is now preferred. We should convert all sendResponse()s to Promises.
@pipboy96
Copy link
Contributor

pipboy96 commented Mar 1, 2020

@Hainish I am working on this right now.

@pipboy96 pipboy96 self-assigned this Mar 1, 2020
@cschanaj
Copy link
Collaborator

@pipboy96 are you still working on this?

@pipboy96
Copy link
Contributor

@cschanaj Yes.

@zoracon zoracon self-assigned this Nov 17, 2020
@zoracon zoracon closed this as completed Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zoracon zoracon

@pipboy96 pipboy96

Labels
code-style minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Hainish @zoracon @cschanaj @pipboy96