-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API not RESTful #74
Comments
That sounds like a good idea, if you want please go ahead and fix it in the v2_dev branch. This will becoming the new release |
Fixed with #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While I was working on #73, I noticed that the API (including the one in the v2 dev branch) is not really RESTful. Would you be open to collaborating/merging a PR for making it so?
As an example:
GET /api/settings/request
=>GET /api/settings
POST /api/settings/change
=>POST (or PATCH) /api/settings
to achieve the typical CRUD-over-REST API style,
as well as
GET /api/system/reboot
toPOST /api/system/reboot
to satisfy the RESTful requirement ofGET
requests not having side-effects.The text was updated successfully, but these errors were encountered: