Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API not RESTful #74

Closed
mmalecki opened this issue May 2, 2024 · 4 comments
Closed

API not RESTful #74

mmalecki opened this issue May 2, 2024 · 4 comments

Comments

@mmalecki
Copy link
Contributor

mmalecki commented May 2, 2024

While I was working on #73, I noticed that the API (including the one in the v2 dev branch) is not really RESTful. Would you be open to collaborating/merging a PR for making it so?

As an example:

  • GET /api/settings/request => GET /api/settings
  • POST /api/settings/change => POST (or PATCH) /api/settings
    to achieve the typical CRUD-over-REST API style,
    as well as GET /api/system/reboot to POST /api/system/reboot to satisfy the RESTful requirement of GET requests not having side-effects.
@seeul8er
Copy link
Contributor

seeul8er commented May 2, 2024

That sounds like a good idea, if you want please go ahead and fix it in the v2_dev branch. This will becoming the new release

@mmalecki
Copy link
Contributor Author

mmalecki commented May 8, 2024

Thanks @seeul8er. Code changes made in #76, just struggling to find out how to get the frontend built, any advice welcome :).

@seeul8er
Copy link
Contributor

seeul8er commented May 8, 2024

Thanks! Unfortunately I have not setup an automated build so far. You have to manually copy & paste the index.html to the frontend folder.
Then I usually run the dronebridge.js content through minify-js and paste it instead of the link to the script. I do the same for CSS content using minifier.

@seeul8er
Copy link
Contributor

Fixed with #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants