Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some inconsistencies in reported flightmodes #1068

Closed
frikzy opened this issue Sep 15, 2014 · 14 comments
Closed

Some inconsistencies in reported flightmodes #1068

frikzy opened this issue Sep 15, 2014 · 14 comments
Assignees

Comments

@frikzy
Copy link

frikzy commented Sep 15, 2014

In Droidplanner v2.7.5 RC1 there are some inconsistencies in reported flightmodes (I belive in other releases too). PosHold is reported as "Hybrid" (also as voice) and RTH is reported as "RTL", but in voice as "Return to Home" which is correct. Other flightmodes that I tested: Stabilize, AltHold, Loiter and Drift are OK.

@arthurbenemann
Copy link
Member

Can you make a list inconsistencies? Also please report what firmware version you are using.

@frikzy
Copy link
Author

frikzy commented Sep 15, 2014

I am using Arducopter v3.2_RC9 firmware.
APM Flightmode / Droidplanner v2.7.6_RC1 (voice)
0 STABILIZE / Stabilize (Stabilize) - OK
1 ACRO / Acro (Acrobatic) - OK
2 ALT_HOLD / AltHold (Altitude Hold) - OK
3 AUTO / Auto (Auto) - OK
4 GUIDED / Guided (Guided) - OK
5 LOITER / Loiter (Loiter) - OK
6 RTL / RTL (Return to Home) - It should be Return to Launch in voice, but it's not big issue
7 CIRCLE / Circle (Circle) - OK
9 LAND / Land (Land) - OK
10 OF_LOITER / Not checked - Hold a single location using optical flow sensor
11 DRIFT / Drift (Drift) - OK
13 SPORT / Sport (Sport) - OK
14 FLIP / Not checked
15 AUTOTUNE / Not checked
16 POSHOLD / Hybrid (Hybrid) - NOT OK, Hybrid is no more used - It has to be PosHold

I hope that this helps a little.

@arthurbenemann
Copy link
Member

@frikzy Thanks, that's very helpful

@squilter
Copy link
Member

@frikzy Are you sure that it's supposed to be "PosHold"? The ArduCopter 3.2 beta testing forum references Hybrid mode twice in the description, but never once mentions "PosHold".

@frikzy
Copy link
Author

frikzy commented Sep 21, 2014

Hybrid was the first proposal for the new mode (hybrid of "Loiter" and "AltHold"), but later with release of 3.2 beta it ws renamed to "PosHold". That's what I know about it.

@squilter
Copy link
Member

@rmackay9 Is it PosHold or Hybrid?

@rmackay9
Copy link

PosHold.

@squilter
Copy link
Member

@frikzy okay, you're right.

Re: number 6 on that list, I thought RTL stood for Return to Launch (not ' return to land').

@frikzy
Copy link
Author

frikzy commented Sep 25, 2014

Yes, that's right. It's "Return to Launch", my mistake.

@squilter
Copy link
Member

Okay, I'll try to fix this tomorrow.

@squilter squilter self-assigned this Sep 25, 2014
@squilter
Copy link
Member

@arthurbenemann we already have a ROTOR_POSITION. I can easily remove all of the fragments and whatever associated with Hybrid, but why does it think PosHold is Hybrid?

@arthurbenemann
Copy link
Member

This is the most likely culprit: https://github.com/DroidPlanner/droidplanner/blob/master/Mavlink/src/com/MAVLink/Messages/ApmModes.java#L33 look at the second parameter of the enum.

@squilter
Copy link
Member

bug feature
What's the difference?

@Thalek
Copy link

Thalek commented Sep 27, 2014

A feature is something you deliberately put in to a program. A bug is something you accidentally put into a program. Usually described as a "feature" by the Marketing Department. [grin]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants