Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File header code fix should only replace the copyright element #1434

Closed
sharwell opened this issue Sep 9, 2015 · 2 comments
Closed

File header code fix should only replace the copyright element #1434

sharwell opened this issue Sep 9, 2015 · 2 comments
Assignees
Milestone

Comments

@sharwell
Copy link
Member

sharwell commented Sep 9, 2015

An XML file header may contain additional elements, including the following:

  1. Horizontal bars (the series of ----------------- characters)
  2. A <summary> element
  3. Other XML elements
  4. Other text outside of XML elements

Expected behavior

When the file header code fix corrects the <copyright> element, each of these other elements should be preserved.

Actual behavior

When the file header code fix corrects the <copyright> element, the entire header is replaced (each of the items is lost).

@peteri
Copy link
Contributor

peteri commented Sep 14, 2015

Going to have a look at this as I got burnt by it today.

@sharwell sharwell modified the milestone: 1.0.0 RC 1 Sep 17, 2015
@peteri
Copy link
Contributor

peteri commented Sep 19, 2015

Fixed and pull request issued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants