Bug: Neither SA1304 nor SA1307 is reported for public readonly fields

[ghost]

Hi,

It seems like both analyzers rely to each other to report a warning and no warning is generated at all. Here's a simple example (StyleCop.Analyzers 1.0.0.8):

#pragma warning disable SA1401 // Fields must be private
public class Class1
{
    // no warning here
    public readonly int sa1304or1307shouldBeReportedHere;
}

[pdelvo]

Yes this looks like a 🐛 to me. The source code for SA1304 clearly says that SA1307 should take precedence.

Do you want to work on this yourself or should someone take a look at this?

[ghost]

No, I just wanted to report a bug. However, I think the fix is just to remove || declaration.Modifiers.Any(SyntaxKind.ReadOnlyKeyword) in SA1307AccessibleFieldsMustBeginWithUpperCaseLetter.cs, line 63 (provided that SA1307 should have priority in this case).

[pdelvo]

Yes this should fix it. Im going to grab this

[sharwell]

Thanks for the 🐛 report @test20150828!