Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1514 seems to be unaware of regions #1231

Closed
RalfKoban opened this issue Aug 17, 2015 · 2 comments
Closed

SA1514 seems to be unaware of regions #1231

RalfKoban opened this issue Aug 17, 2015 · 2 comments
Assignees
Milestone

Comments

@RalfKoban
Copy link
Contributor

Hi,

I'm using 1.0.0 Beta 7.
The SA1514 rule seems to be got unaware of regions, because I get a violation e.g. in following snippet:

    #region Fields

    /// <summary>
    /// Contains some data.
    /// </summary>
    private object someData;

    #endregion

In Beta 6 that was working.

Best regards,
Ralf

@sharwell
Copy link
Member

I'm thinking for most cases of preprocessor directives, we need to avoid reporting this warning whether or not there is a blank line before the documentation comment. The exceptions are:

  • Must have a blank line if preceded by:
    • #endif
    • #region
    • #endregion

@Noryoko what do you think about this? Since the others would allow either including or omitting the blank line it should stop the false positives. If I missed one that should be checked we could always special case that one later.

@Noryoko
Copy link
Contributor

Noryoko commented Aug 17, 2015

Sounds good to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants