Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Subgrid layout #468

Open
Tracked by #345
nicoburns opened this issue Apr 24, 2023 · 2 comments
Open
Tracked by #345

Support Subgrid layout #468

nicoburns opened this issue Apr 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@nicoburns
Copy link
Collaborator

nicoburns commented Apr 24, 2023

What problem does this solve or what need does it fill?

Subgrid layout is useful when creating nested grids.

What solution would you like?

Implement support for grid-template-columns: subgrid and grid-template-rows: subgrid in Taffy:

Additional context

Much like block layout, subgrid layout requires access to non-direct descendants of a node, so some design work will be required to create an API that allows for this.

@nicoburns nicoburns added the enhancement New feature or request label Apr 24, 2023
@nicoburns nicoburns mentioned this issue Apr 24, 2023
37 tasks
@nicoburns nicoburns moved this to Todo in 🍬 Taffy Roadmap Jan 7, 2024
@jrmoulton
Copy link

jrmoulton commented Sep 21, 2024

I'm really interested in having subgrid.

I'm definitely not qualified but I can work on this if no one else is.

Now that block layout has been merged, is there still design work that needs to be done?

@nicoburns

@nicoburns nicoburns changed the title Support CSS Subgrid layout (Display::Subgrid) Support CSS Subgrid layout Dec 4, 2024
@nicoburns
Copy link
Collaborator Author

@jrmoulton

Now that block layout has been merged, is there still design work that needs to be done?

Block layout isn't really using this yet, but there is a design for this now. The trick is that each algorithm now takes it's own trait as a parameter. So we can add algorithm-specific methods to that trait, one of which can be to get access to items in a subgridded axis.

@nicoburns nicoburns changed the title Support CSS Subgrid layout Support Subgrid layout Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants