Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same seed should produce same password for person #130

Open
rweisleder opened this issue May 25, 2020 · 0 comments · May be fixed by #131
Open

Same seed should produce same password for person #130

rweisleder opened this issue May 25, 2020 · 0 comments · May be fixed by #131

Comments

@rweisleder
Copy link
Contributor

Given the following snippet

Person person1 = Fairy.builder().withLocale(Locale.ENGLISH).withRandomSeed(1).build().person();
System.out.println(person1.getUsername() + ":" + person1.getPassword());

Person person2 = Fairy.builder().withLocale(Locale.ENGLISH).withRandomSeed(1).build().person();
System.out.println(person2.getUsername() + ":" + person2.getPassword());

I would expect that the username and password are the same because I use the same seed.

Currently (v0.6.4), the password is always different.

andrewm:toql0chK
andrewm:JMRluePu

This issue makes it difficult to create reproducible fake data.
rweisleder added a commit to rweisleder/jfairy that referenced this issue May 27, 2020
@rweisleder
Ensure same passwords for same random seeds
8c4d870 
Fixes Devskiller#130
@rweisleder rweisleder linked a pull request May 27, 2020 that will close this issue
Open
rweisleder added a commit to rweisleder/jfairy that referenced this issue May 28, 2020
@rweisleder
Ensure same passwords for same random seeds
9817525 
Fixes Devskiller#130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure same passwords for same random seeds rweisleder/jfairy
1 participant
@rweisleder