Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Text Utilities tool to DevToys 2.0 + More UI fixes #985

Merged
merged 3 commits into from
Nov 25, 2023

Conversation

veler
Copy link
Collaborator

@veler veler commented Nov 24, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

DevToys 2.0 lacks of Text Utilities tool

What is the new behavior?

Added Text Utilities tool to DevToys 2.0.
It includes some changes compared to DevToys 1.0:

  1. Support of \r\n, \r and \n line break (DevToys 1.0 only supports \r\n)
  2. Added some buttons to convert the line break to \r\n and \n (didn't do \r because it's only supported on MacOS 9 and older)
  3. As part of the analyze we perform, we now indicate whether the text uses \r\n, \r, \n or a "mixed" set of line break characters.

Other information

This PR depends on changes introduced in #983

image

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added the devtoys-v2.0 DevToys v2.0 label Nov 24, 2023
@veler veler requested a review from btiteux November 24, 2023 21:14
Base automatically changed from dev/2.0-regextester to dev/2.0 November 25, 2023 16:49
@veler veler merged commit f640364 into dev/2.0 Nov 25, 2023
@veler veler deleted the dev/2.0-text-utilities branch November 25, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants