Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Regex Tester to DevToys 2.0 + Various fixes #983

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

veler
Copy link
Collaborator

@veler veler commented Nov 20, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

DevToys 2.0 lacks of Regex Tester too, along with suffers from some bugs and lack of answers to some customer requests.

Issue Number: #885, #736, #681, #409

What is the new behavior?

Added RegEx Tester to DevToys 2.0.

To achieve it, I needed to fix various bugs to our Monaco wrapper, our Data Grid component and Label component. It includes:

  1. Added support of colorful highlighting to Monaco through our API.
  2. Remove support of custom selection to Single Line Text Input because there's no API to change the selection in an <input type=text/> outside of SelectAll.
  3. Fixed some bugs where DataGrid UI wasn't updating correctly after updating its content.
  4. Fixed a bug in Label/TextBlock related to how text wraps.
  5. Fixed a bug where Label theme wasn't applied correctly when the component was virtualized into a DataGrid.
  6. Fixed a bug where we were triggering Smart Detection for no good reason.

Other information

image

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler merged commit b56a022 into dev/2.0 Nov 25, 2023
@veler veler deleted the dev/2.0-regextester branch November 25, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0
Projects
None yet
2 participants