Part 2: 638 Feature Request: password generator with options

[micahmo]

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• New feature or enhancement
• UI change (please include screenshot!)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Internationalization and localization
• Other (please describe):

What is the current behavior?

Issue Number: #638

What is the new behavior?

This is a continuation of the work started in #664.

Other information

I believe I have addressed the only two outstanding comments from the original PR which were...

Adding a new icon: I have added the icon suggested by @veler from the FluentSystemIcons font.

Supporting numbers as a toggle: I have added the numbers setting to the UI, and an InfoBar (Warning) is shown if no characters sets are selected.

Quality check

Before creating this PR:

• Did you follow the code style guideline as described in CONTRIBUTING.md
• Did you build the app and test your changes?
• Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
• Did you verify that the change work in Release build configuration
• Did you verify that all unit tests pass
• If necessary and if possible, did you verify your changes on:
  • Windows
  • macOS (DevToys 2.0)
  • Linux (DevToys 2.0)

[micahmo]

Not sure about some of these extra changes and whether they're necessary.

[micahmo]

Hi @veler, it looks like you're full steam ahead with 2.0. I am mostly done adding things I was missing when I first started using DevToys. This PR is just to clean up an old one that was hanging around. Do you have any plans to release a new version of 1.0 soon? Just to hold us over until 2.0 is maybe ready for early testing? 😊

[veler]

Hi @veler, it looks like you're full steam ahead with 2.0. I am mostly done adding things I was missing when I first started using DevToys. This PR is just to clean up an old one that was hanging around. Do you have any plans to release a new version of 1.0 soon? Just to hold us over until 2.0 is maybe ready for early testing? 😊

Hi @micahmo ,

I am so sorry for the delay. I actually started looking at the PR weeks ago and then completely forgot.
You are right, me and @btiteux are fully into DevToys 2.0 at the moment. Things are progressing well but we're still months away from an early release.

I will definitely release the contribution you made soon, before DevToys 2.0. :)

Thank you for this pull request. It looks all good to me. I don't have much comment to make as they were already addressed from the previous PR.