Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT encoding/decoding improvements #859

Merged

Conversation

micahmo
Copy link

@micahmo micahmo commented Jun 13, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

This PR includes a few improvements to JWT encoding/decoding.

  • Allow encoding tokens with RSA private keys
  • Make the header field readonly in encoding mode (since it doesn't currently affect the output, although that could be a future enhancement)
  • Allow validating signature with a certificate containing a public key
  • Fix an issue where the saved token algorithm was not loaded correctly

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler
Copy link
Collaborator

veler commented Jun 14, 2023

@btiteux , as you own this tool and know better about JWT than I do, could you please take a look at this PR? :)

@veler veler requested a review from btiteux June 14, 2023 01:48
@micahmo micahmo mentioned this pull request Jun 28, 2023
18 tasks
Copy link
Collaborator

@btiteux btiteux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, sorry for the late review lot's of stuff in my personal life.

Everything is good for me for this new pull request.

Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much again for this pull request :D !

@veler veler merged commit 1954d5c into DevToys-app:main Jul 5, 2023
@micahmo micahmo deleted the feature/jwt-encoding-decoding-improvements branch July 5, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants