Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAUI Blazor] Improved NavBar + refactoring #811

Merged
merged 14 commits into from
May 20, 2023
Merged

[MAUI Blazor] Improved NavBar + refactoring #811

merged 14 commits into from
May 20, 2023

Conversation

veler
Copy link
Collaborator

@veler veler commented May 15, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

  • Theme update wasn't supported.
  • NavBar wasn't taking consideration of user's preference regarding whether the pane should be collapsed or expanded.
  • NavBar group items would take too much height when expanded.
  • Some NavBar colors, size and animation were off compared to WinUI.

What is the new behavior?

  • More consistent UI with WInUI. For example, items in NavBar are now consistent with WinUI's NavigationViewItem.
  • Scrollbar are now invisible by default, visible on mouse hover, enlarged when the mouse cursor is near the scrollbar.
  • Button theme is now consistent with WinUI.
  • Got rid of FluentUI Blazor library. If needed, we can still pump the styles from it.
  • Got rid of some code that wasn't used.
  • Large refactoring in overall.

Below is Before/After comparison.

Untitled.Project.mp4

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler requested a review from btiteux May 15, 2023 06:24
@veler veler changed the title Dev/2.0 new css [MAUI Blazor] Improved NavBar + refactoring May 15, 2023
@veler veler merged commit e32c6e2 into dev/2.0 May 20, 2023
@veler veler deleted the dev/2.0-new-css branch May 20, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants