Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a single-line text input #779

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Conversation

veler
Copy link
Collaborator

@veler veler commented Mar 31, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

DevToys 2.0 doesn't have a single-line text input yet.

What is the new behavior?

Added a single-line text input control that supports read-only and read-write mode.

Also addressed the following items: #738, #673

Other information

Recording.2023-03-26.222939.mp4

Remaining TO DO:

  • Multiline editor and Diff editor, using Monaco Editor.
  • Drag & Drop a file from File Explorer to DevToys.
  • Smart Detection inside of the text editor (see Transfer output to other tool #737)
  • Keyboard navigation

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler merged commit 0e80f67 into dev/2.0 Apr 1, 2023
@veler veler deleted the dev/2.0-singleline-text-input branch April 1, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save Output to file... Add additional filter file extensions when opening from the "Load a file" button
2 participants