Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetChildElementById no access to elements inside Card #1429

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

jerone
Copy link
Contributor

@jerone jerone commented Oct 27, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Fixes: #1406

What is the new behavior?

  • GetChildElementById now also iterates over UIElement inside UICard.

Other information

Added basic unit tests for GetChildElementById.

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler
Copy link
Collaborator

veler commented Oct 27, 2024

Hello,
Thank you for this fix! It looks great!

@veler veler merged commit 003e38b into DevToys-app:main Oct 27, 2024
2 of 3 checks passed
@jerone jerone deleted the bugfix/#1406-getelementbyid-card branch October 27, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] GetChildElementById doesn't work with Card
2 participants