Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conflict internal name resolution for resource assembly identifier. #1354

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Jul 30, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Some extensions use the same name in IResourceAssemblyIdentifier, and it causes some conflicts internally.

What is the new behavior?

We now test the resource manager and try with a different assembly if it doesn't work. I also updated the documentation (in Documentation repository) to explain that the name should be unique.

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler veler merged commit 16741a7 into main Aug 7, 2024
2 of 3 checks passed
@veler veler deleted the fix-conflict-resolution branch August 7, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant