Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added app icon #1065

Merged
merged 3 commits into from
Feb 24, 2024
Merged

Added app icon #1065

merged 3 commits into from
Feb 24, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Feb 23, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the new behavior?

Updated the app icon on Windows and MacOS.
Linux seems more challenging and isn't covered by this PR. It sounds like it can only be done through a .desktop file, which should be generated dynamically on the customer's machine. In other words, we will have to do this through installation process probably, unless there's an alternative that I didn't find.

Other information

image

image

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added the devtoys-v2.0 DevToys v2.0 label Feb 23, 2024
@veler veler requested a review from btiteux February 23, 2024 23:28
@veler veler changed the title Dev/2.0 added app icon Added app icon Feb 24, 2024
@veler veler merged commit 15ce186 into dev/2.0 Feb 24, 2024
@veler veler deleted the dev/2.0-added-app-icon branch February 24, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants