Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window position and size is now saved and restore when reopening the app #1049

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Feb 10, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

DevToys 2.0's window's size and position weren't saved and restore after closing/starting the app.

What is the new behavior?

We now do it on Windows and MacOS.
We won't do it on Linux because GTK 4 doesn't have an API to move and resize a window (same reason why we don't support Picture-in-Picture)

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added the devtoys-v2.0 DevToys v2.0 label Feb 10, 2024
@veler veler requested a review from btiteux February 10, 2024 01:40
@veler veler merged commit 19b1efa into dev/2.0 Feb 11, 2024
@veler veler deleted the dev/2.0-window-position-settings branch February 11, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants