Ported Text Escape/ Unescape tool

[veler]

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• New feature or enhancement
• UI change (please include screenshot!)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Internationalization and localization
• Other (please describe):

What is the current behavior?

DevToys 2.0 doesn't have a Text Escape / Unescape tool yet

Issue Number: #468

What is the new behavior?

Ported the tool from DevToys 1.0 to 2.0. Issue #468 is solved through the fact that DevToys 2.0 has an option to select what end of line character should be used in Settings. Let's start with this for now. If unhappy, we could create an option specifically in this tool.

Other information

Quality check

Before creating this PR:

• Did you follow the code style guideline as described in CONTRIBUTING.md
• Did you build the app and test your changes?
• Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
• Did you verify that the change work in Release build configuration
• Did you verify that all unit tests pass
• If necessary and if possible, did you verify your changes on:
  • Windows
  • macOS (DevToys 2.0)
  • Linux (DevToys 2.0)

[btiteux]

I'm ok with the pull request but we need some Unit Tests on the GUI :)

Before merging this pull request #971 , we have one to add support for Linux escape lines, too. Can we add the support at the same time?

[veler]

Hey @btiteux

Before merging this pull request #971 , we have one to add support for Linux escape lines, too. Can we add the support at the same time?

As I said in the PR description, issue #468 (which #971 solves in DevToys 1.0) is solved through the fact that DevToys 2.0 has an option to select what end of line character should be used in Settings. I'd suggest to limit ourselves to this for now and wait for more feedback. The setting I'm referring to above has already been tested on Linux.

Another thing I realize I forgot to mention in the PR description is that user can also convert the end of line sequence characters using Text Utilities tool. This is also new in DevToys 2.0.

Note that \r (Mac) is not supported by Monaco. Note also that \r on Mac is not supported after Mac OS 9, which DevToys doesn't target anyway.

[veler]

we need some Unit Tests on the GUI :)

Done :-)

[btiteux]

We can go with the settings for the moment. But I think it's more user friendly to have a list here and that would avoid changing the settings for the whole apps.

[veler]

We can go with the settings for the moment. But I think it's more user friendly to have a list here and that would avoid changing the settings for the whole apps.

I ultimately agree :-)