Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Lorem Ipsum generator to DevToys 2.0 #1004

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Conversation

veler
Copy link
Collaborator

@veler veler commented Dec 17, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

DevToys 2.0 doesn't have Lorem Ipsum generator yet.

What is the new behavior?

Ported Lorem Ipsum generator. I also added an option that allows to use more corpus, as requested in #980.
In addition, instead of taking dependency on the library NLipsum like we do in DevToys 1.0, I forked the code. The reason why is that this library isn't maintained anymore and uses .NET Standard 1.0, which would requires DevToys 2.0 to ship with many more DLLs.

Other information

image

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added the devtoys-v2.0 DevToys v2.0 label Dec 17, 2023
@veler veler requested a review from btiteux December 17, 2023 22:55
@veler veler linked an issue Dec 17, 2023 that may be closed by this pull request
@veler veler merged commit 9f410d5 into dev/2.0 Dec 26, 2023
@veler veler deleted the dev/2.0-lorem-ipsum branch December 26, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lorem Ipsum: Generate other languages' Lorem.
2 participants