Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Reduction.are_convertible_lst calls term_eq ? #279

Open
fblanqui opened this issue Jun 15, 2022 · 5 comments
Open

Why Reduction.are_convertible_lst calls term_eq ? #279

fblanqui opened this issue Jun 15, 2022 · 5 comments

Comments

@fblanqui
Copy link
Member

This has been pointed to me by @01mf02.
It looks useless and inefficient.
The code of conversion_step looks strange too (calls to snf).

@francoisthire
Copy link
Collaborator

See #280 for a partial answer. It does not seem useless nor inefficient.

The call to snf was introduced by @Gaspi for the AC feature. I cannot explain why this is necessary but there is a TODO above.

@francoisthire
Copy link
Collaborator

I would be curious to know how lambdapi behaves on the test tests/OK/sharing.dk.

@gabrielhdt
Copy link
Member

I think your answer is there: Deducteam/lambdapi#313

@fblanqui
Copy link
Member Author

I see. It would be good to add a comment about this in the code.

@francoisthire
Copy link
Collaborator

I have updated #280 with a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants