Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a brew formula #121

Closed
olekslitus opened this issue Jun 7, 2021 · 8 comments · Fixed by #129
Closed

Create a brew formula #121

olekslitus opened this issue Jun 7, 2021 · 8 comments · Fixed by #129
Labels
enhancement New feature or request

Comments

@olekslitus
Copy link

It would be great to add brew formula for Mac users.

@David-OConnor David-OConnor added the enhancement New feature or request label Jun 7, 2021
@David-OConnor
Copy link
Owner

Would this allow me or someone else to build for Mac without owning one? This is why the Mac binaries are generally out of date.

@olekslitus
Copy link
Author

Sadly no. brew is simply a package manager that lets you distribute binaries easily.
I am not sure if it is possible to make brew formula that compiles from source, but I can check if that would be interesting to you.

@David-OConnor
Copy link
Owner

Thanks for the follow up. Native mac binaries and Brew would be great, but I think as it stands, the best bet for Mac users is to install Rust, then cargo install pyflow.

@branchvincent
Copy link
Contributor

hey @David-OConnor! I hit a small snag trying to create a brew formula. The latest tagged release doesn't include a necessary fix to compile on MacOS: a2bf3ce. Brew understandably disallows new formula that require a patch to build and has asked if we can either:

  • Tag a new (unplanned) release with this fix
  • Get an idea for when the next release is planned

@branchvincent
Copy link
Contributor

Would this allow me or someone else to build for Mac without owning one? This is why the Mac binaries are generally out of date.

And to answer this, creating a Homebrew formula indeed means that Homebrew's CI will build/distribute binaries for Intel machines on MacOS 10.14/10.15/11 as well as ARM machines on MacOS 11!

And when pyflow has a new release, updating Homebrew's version involves creating a PR that is usually as simple as brew bump-formula-pr pyflow --version=x.y.z (unless any build-related changes occurred). If desired, you could of course integrate this as part of your release process (for example, see GitHub's CLI and starship).

@David-OConnor
Copy link
Owner

Released as 0.3.0.1

Let me know if the 4-part non-semvar release name causes trouble.

Glad to hear about the easy Mac releases!

@branchvincent
Copy link
Contributor

Thanks for the quick release, you can now brew install pyflow!

@David-OConnor
Copy link
Owner

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants