Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Attach schema name as tag with index usage metrics #19266

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

azhou-datadog
Copy link
Contributor

What does this PR do?

Will send the associated schema name along with index usage metrics

Motivation

This aligns sqlserver's metrics around index usage that postgres provides, which allows us to give a detailed unused index recommendation.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (2ea7fe9) to head (fe31766).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 89.92% <100.00%> (+8.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@azhou-datadog azhou-datadog changed the title Attach schema name as tag with index usage metrics DRAFT: Attach schema name as tag with index usage metrics Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants