Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTPLAT-448] DDSaaS: Temporal Cloud Crawler Integration v1.0.0 #19250

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

mauneelsorathia-crest
Copy link
Contributor

What does this PR do?

  • This is an initial release PR of Temporal Cloud integration including all the required assets.

Motivation

  • Crawler code for this integration has been committed in its respective repo.
  • The assets are available in our sandbox and can be shared separately with the required teams.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@mauneelsorathia-crest mauneelsorathia-crest marked this pull request as ready for review December 11, 2024 13:20
@mauneelsorathia-crest mauneelsorathia-crest changed the title DDSaaS: Temporal Cloud Crawler Integration v1.0.0 [INTPLAT-448] DDSaaS: Temporal Cloud Crawler Integration v1.0.0 Dec 11, 2024
@drichards-87 drichards-87 self-assigned this Dec 11, 2024
@drichards-87 drichards-87 added the editorial review Waiting on a more in-depth review from a docs team editor label Dec 11, 2024
@drichards-87 drichards-87 removed their assignment Dec 11, 2024
@drichards-87
Copy link
Contributor

Created Jira card for Docs Team editorial review.

@@ -1,41 +1,56 @@
## Overview

This check monitors [Temporal_Cloud][1].
[Temporal Cloud][1] is a scalable platform for orchestrating complex workflows, with built-in reliability, resilience and timing controls enabling developers to focus on application logic without worrying about fault tolerance and consistency.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Temporal Cloud][1] is a scalable platform for orchestrating complex workflows, with built-in reliability, resilience and timing controls enabling developers to focus on application logic without worrying about fault tolerance and consistency.
[Temporal Cloud][1] is a scalable platform for orchestrating complex workflows, with built-in reliability, resilience, and timing controls. Temporal Cloud enables developers to focus on application logic without worrying about fault tolerance and consistency.

[Temporal Cloud][1] is a scalable platform for orchestrating complex workflows, with built-in reliability, resilience and timing controls enabling developers to focus on application logic without worrying about fault tolerance and consistency.


This integration collects Temporal Cloud metrics and directs them into Datadog to provide insights into system health, workflow efficiency, task execution and performance bottlenecks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This integration collects Temporal Cloud metrics and directs them into Datadog to provide insights into system health, workflow efficiency, task execution and performance bottlenecks.
This integration collects Temporal Cloud metrics and directs them into Datadog to provide insights into system health, workflow efficiency, task execution, and performance bottlenecks.

### Installation
### Generate Metrics Endpoint URL in Temporal Cloud

1. In order to generate security CA Certificate and End-entity Certificate refer to this [link][2].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. In order to generate security CA Certificate and End-entity Certificate refer to this [link][2].
1. To generate a CA certificate and an end-entity certificate, see [certificate management][2].

### Generate Metrics Endpoint URL in Temporal Cloud

1. In order to generate security CA Certificate and End-entity Certificate refer to this [link][2].
- **Note**: It is recommended to define longer expiry duration of the certificates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Note**: It is recommended to define longer expiry duration of the certificates.
- **Note**: An expired root CA certificate invalidates all downstream certificates. To avoid disruptions to your systems, use certificates with long validity periods.


1. In order to generate security CA Certificate and End-entity Certificate refer to this [link][2].
- **Note**: It is recommended to define longer expiry duration of the certificates.
2. Log in to [Temporal Cloud][3] with an Account Owner or Global Admin role.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Log in to [Temporal Cloud][3] with an Account Owner or Global Admin role.
2. Log in to [Temporal Cloud][3] with an account owner or global admin role.


## Setup

### Installation
### Generate Metrics Endpoint URL in Temporal Cloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Generate Metrics Endpoint URL in Temporal Cloud
### Generate a Metrics endpoint URL in Temporal Cloud

|--------------------|--------------------|
|Account ID|Temporal Cloud account ID to be used as part of metrics endpoint URL: https://<account_id>.tmprl.cloud/prometheus.|
|End-entity Certificate file content|Content of End-entity Certificate for secure access and communication with Metrics Endpoint.|
|End-entity Certificate key file content|Content of End-entity Certificate key for secure access and communication with Metrics Endpoint.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|End-entity Certificate key file content|Content of End-entity Certificate key for secure access and communication with Metrics Endpoint.|
|End-entity certificate key file content|Content of the end-entity certificate key for secure access and communication with the Metrics endpoint.|


### Validation
2. Click the Save button to save your settings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Click the Save button to save your settings.
2. Click the **Save** button to save your settings.


## Data Collected

### Metrics

Temporal_Cloud does not include any metrics.
The Temporal Cloud integration collects and forwards Frontend Service metrics, Poll metrics, Replication lag metrics, Schedule metrics, Service latency metrics and Workflow metrics to Datadog. See [metadata.csv][4] for a list of metrics provided by this integration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Temporal Cloud integration collects and forwards Frontend Service metrics, Poll metrics, Replication lag metrics, Schedule metrics, Service latency metrics and Workflow metrics to Datadog. See [metadata.csv][4] for a list of metrics provided by this integration.
See [metadata.csv][4] for a list of metrics provided by this integration.

The above is a magic phrase that embeds the table of metrics in the integration doc. It needs to be the only text under the Metrics heading in order for the code that inserts the table to work.

temporal_cloud.cloud_metrics.v0_replication_lag_p99,gauge,,second,,P99 value using histogram of replication lag during a specific time interval for a multi-region Namespace.,-1,temporal_cloud,Replication Lag P59,,
temporal_cloud.cloud_metrics.v0_resource_exhausted_error_increase1m,count,60,,,Increase in gRPC requests received that were rate-limited,-1,temporal_cloud,Resource Exhausted Error,,
temporal_cloud.cloud_metrics.v0_schedule_action_success_increase1m,count,60,,,Increase in count of successful execution of a Scheduled Workflow.,1,temporal_cloud,Schedule Action Success,,
temporal_cloud.cloud_metrics.v0_schedule_buffer_overruns_increase1m,count,60,,,"When average schedule run length is greater than average schedule interval while a buffer_all overlap policy is configured, this is increase in count of such scheduled workflow executions",-1,temporal_cloud,Schedule Buffer Overruns,,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
temporal_cloud.cloud_metrics.v0_schedule_buffer_overruns_increase1m,count,60,,,"When average schedule run length is greater than average schedule interval while a buffer_all overlap policy is configured, this is increase in count of such scheduled workflow executions",-1,temporal_cloud,Schedule Buffer Overruns,,
temporal_cloud.cloud_metrics.v0_schedule_buffer_overruns_increase1m,count,60,,,"When average schedule run length is greater than average schedule interval while a buffer_all overlap policy is configured, this is the increase in count of such scheduled workflow executions",-1,temporal_cloud,Schedule Buffer Overruns,,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants