Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(telemetry): avoids stopping periodic threads in telemetry writer atexit hooks #11708

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(telemetry): avoids stopping periodic threads in telemetry writer atexit hooks #11708

wants to merge 6 commits into from
+14 −18

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Dec 12, 2024 •
edited
Loading

Resolves: #11622

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions GitHub Actions
Copy link
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/telemetry-deadlocks-ea3f457ab0611c8b.yaml            @DataDog/apm-python
ddtrace/internal/telemetry/writer.py                                    @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Dec 12, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-12-13 16:50:18

Comparing candidate commit 436b294 in PR branch munir/fix-telemetry-deadlocks with baseline commit 54aaf57 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur marked this pull request as ready for review December 13, 2024 16:10
@mabdinur mabdinur requested review from a team as code owners December 13, 2024 16:10
@mabdinur mabdinur requested a review from erikayasuda December 13, 2024 16:10
@mabdinur mabdinur enabled auto-merge (squash) December 13, 2024 18:57
@mabdinur mabdinur requested a review from P403n1x87 December 13, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmettbutler emmettbutler emmettbutler approved these changes

@gnufede gnufede Awaiting requested review from gnufede gnufede is a code owner automatically assigned from DataDog/apm-python

@vitor-de-araujo vitor-de-araujo Awaiting requested review from vitor-de-araujo vitor-de-araujo is a code owner automatically assigned from DataDog/apm-python

@erikayasuda erikayasuda Awaiting requested review from erikayasuda erikayasuda is a code owner automatically assigned from DataDog/apm-core-python

@P403n1x87 P403n1x87 Awaiting requested review from P403n1x87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition at shutdown in ddtrace 2.11.1 (possibly later.)
2 participants
@mabdinur @emmettbutler