-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Second life ?] 1.4 support #17
Comments
I may create a PR with a fix or create another repo, it's all about if @DanielDent is still active. |
A good PR will be appreciated and merged. Currently going through existing issues and I'm going to look at merging and what updates are needed. Thanks for your patience - I know it's been a long time since this repo was updated. |
https://github.com/DanielDent/docker-meteor/blob/master/latest/meteor-installer.patch
inside the sourcecode, it look like a git diff but it is inside the source code. |
It's used to adjust the installer so that it supports installing a specific version. |
No I do not asked for an explanation 'bout this line I ask you why in source code (EVEN when one download it locally so it's not only a diff visible on github) : This look like a diff between two version of a file but when I download your source code of https://github.com/DanielDent/docker-meteor/blob/master/latest/meteor-installer.patch I still have these kind of diff lines. |
Still I have a question, I'm not against helping but why do you update docker's repo but not Github's one ? |
I think I'm going to give up w/ docker and use another way of deployment as pm2-meteor or something else. Anyway as I said I tested it and just add
|
As dev showed in another issue brieve signal of a desire of updating this repo I open this issue to say that first thing to do is to stop using root as user, or to use the
--allow-superuser
option when launchingmeteor
otherwisemeteor
is not gonna working (either to compile or to watch file in dev mode) giving the error message :I also want to know what is the future of this package, multiple updates on docker has been made but github hasn't been updated. As there's activity on this package I'm probably gonna use this dockerfile if your going to support this package in the future so could you please declare for devs like me your plans about this package.
The text was updated successfully, but these errors were encountered: