Fix memory allocation issue when destroying a ConvexMesh

DanielChappuis · Jun 6, 2024 · 85fbcf8 · 85fbcf8
1 parent 1c2b817
commit 85fbcf8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 
 - Issue [#377](https://github.com/DanielChappuis/reactphysics3d/issues/377) Assert when destroying an empty PhysicsWorld
 - Issue [#378](https://github.com/DanielChappuis/reactphysics3d/issues/378) Wrong raycasting result against the HeightFieldShape
+- Issue [#387](https://github.com/DanielChappuis/reactphysics3d/issues/387) Fix memory allocation issue when destroying a ConvexMesh
 - Fix crash within testbed application in raycasting scene
 - Fix robustness issue with CapsuleShape vs CapsuleShape collision
 

diff --git a/src/engine/PhysicsCommon.cpp b/src/engine/PhysicsCommon.cpp
@@ -617,7 +617,7 @@ ConvexMesh* PhysicsCommon::createConvexMesh(const PolygonVertexArray& polygonVer
     // If the mesh is not valid
     if (!isValid) {
         mesh->~ConvexMesh();
-        allocator.release(mesh, sizeof(ConvexMesh));
+        mMemoryManager.release(MemoryManager::AllocationType::Pool, mesh, sizeof(ConvexMesh));
         return nullptr;
     }
 
@@ -661,7 +661,7 @@ ConvexMesh* PhysicsCommon::createConvexMesh(const VertexArray& vertexArray, std:
     // If the mesh is not valid
     if (!isValid) {
         mesh->~ConvexMesh();
-        allocator.release(mesh, sizeof(ConvexMesh));
+        mMemoryManager.release(MemoryManager::AllocationType::Pool, mesh, sizeof(ConvexMesh));
         return nullptr;
     }