Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getParentNode interface for folderTreeService #752

Merged
merged 3 commits into from
May 30, 2022

Conversation

mumiao
Copy link
Collaborator

@mumiao mumiao commented May 25, 2022

Description

there is a easier way to get the current treeNode's parentNode?

Fixes #723

Changes

Please describe the changes, help the reviewer to read your code.

  • add getParentNode interface for folderTreeService
  • add Unit test for folderTreeService.getParentNode

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@mumiao mumiao requested review from mortalYoung, wewoor and Zaoei May 25, 2022 10:39
@mumiao mumiao self-assigned this May 25, 2022
@mumiao mumiao added the feature label May 25, 2022
@mumiao mumiao added this to the 0.9.0-beta.5 milestone May 25, 2022
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #752 (f5052ee) into main (52d79b0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
+ Coverage   91.38%   91.39%   +0.01%     
==========================================
  Files         189      189              
  Lines        5952     5959       +7     
  Branches     1428     1431       +3     
==========================================
+ Hits         5439     5446       +7     
  Misses        506      506              
  Partials        7        7              
Impacted Files Coverage Δ
...c/services/workbench/explorer/folderTreeService.ts 99.46% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d79b0...f5052ee. Read the comment docs.

Copy link
Collaborator

@Zaoei Zaoei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 4c09eea into main May 30, 2022
@wewoor wewoor deleted the feat/treeService branch May 30, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a easier way to get the current treeNode's parentNode?
4 participants