Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the enter character \u21a9 #746

Merged
merged 1 commit into from
May 20, 2022

Conversation

Zaoei
Copy link
Collaborator

@Zaoei Zaoei commented May 19, 2022

Description

an extra empty string was split due to \ufe0e

Fixes #721

Changes

// old
'↩︎'.split('') // ['↩', '︎'] \u21a9\ufe0e
// new
'↩'.split('') // ['↩'] \u21a9

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Zaoei Zaoei requested review from mortalYoung, mumiao and wewoor May 19, 2022 15:11
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #746 (f4478d3) into main (05ad264) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #746   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files         189      189           
  Lines        5947     5947           
  Branches     1426     1425    -1     
=======================================
  Hits         5432     5432           
  Misses        508      508           
  Partials        7        7           
Impacted Files Coverage Δ
src/model/keybinding.ts 100.00% <ø> (ø)
src/components/tabs/tab.tsx 100.00% <0.00%> (ø)
src/components/tabs/tabExtra.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ad264...f4478d3. Read the comment docs.

Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mortalYoung mortalYoung added the bug Something isn't working label May 20, 2022
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 7fd02ab into DTStack:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: there is an unseen string
3 participants