Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable click event when action is disabled #745

Merged
merged 2 commits into from
May 24, 2022

Conversation

Zaoei
Copy link
Collaborator

@Zaoei Zaoei commented May 19, 2022

Description

The disable button can also trigger events

Fixes #725

Changes

Add disable restrictions

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Zaoei Zaoei requested review from mortalYoung, mumiao and wewoor May 19, 2022 15:03
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #745 (9fea0b3) into main (05ad264) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
+ Coverage   91.34%   91.37%   +0.03%     
==========================================
  Files         189      189              
  Lines        5947     5948       +1     
  Branches     1426     1426              
==========================================
+ Hits         5432     5435       +3     
+ Misses        508      506       -2     
  Partials        7        7              
Impacted Files Coverage Δ
src/workbench/editor/action.tsx 89.74% <100.00%> (+5.12%) ⬆️
src/components/tabs/tab.tsx 100.00% <0.00%> (ø)
src/components/tabs/tabExtra.tsx 100.00% <0.00%> (ø)
src/components/breadcrumb/index.tsx 93.33% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ad264...9fea0b3. Read the comment docs.

@mortalYoung
Copy link
Collaborator

覆盖率有点不达标,可以为这个改动加一条测试用例

@Zaoei Zaoei force-pushed the fix/editorOperationClickDisable branch from 1b6526c to 9fea0b3 Compare May 20, 2022 07:20
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit ad0310d into DTStack:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the action in editor still work although I set it to disabled
3 participants