Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import Icon, Toolbar from relative path #692

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Mar 4, 2022

Description

修改 Icon,Toolbar 组件在 Collapse 中的引用位置。
从 index 引入会造成循环引用的问题,造成不可预知的 Bug.

Changes

  • 修改为相对路径的引用

@wewoor wewoor requested a review from mortalYoung March 4, 2022 08:08
@wewoor wewoor added the bug Something isn't working label Mar 4, 2022
@wewoor wewoor force-pushed the fix/collpase-depen branch from c23fbf2 to fab0508 Compare March 4, 2022 08:10
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #692 (fab0508) into main (65dfac6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files         189      189           
  Lines        5943     5943           
  Branches     1429     1429           
=======================================
  Hits         5398     5398           
  Misses        538      538           
  Partials        7        7           
Impacted Files Coverage Δ
src/components/collapse/index.tsx 98.51% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65dfac6...fab0508. Read the comment docs.

Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit a95fbe2 into main Mar 4, 2022
@wewoor wewoor deleted the fix/collpase-depen branch March 4, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants