Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the interaction bug of MenuBar in horizontal mode #647

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

kiwiwong
Copy link
Collaborator

@kiwiwong kiwiwong commented Feb 10, 2022

Description

修复了在 Taiga 中点击 MenuBar 的菜单项并关闭了菜单后,再 hover 菜单项时仍会自动展示菜单的问题。

Changes

  • Optimized the interaction logic of MenuBar in horizontal mode.

@kiwiwong kiwiwong added the bug Something isn't working label Feb 10, 2022
@kiwiwong kiwiwong self-assigned this Feb 10, 2022
@wewoor wewoor requested review from wewoor and mortalYoung February 10, 2022 08:28
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #647 (c3a2048) into main (1c776c7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #647   +/-   ##
=======================================
  Coverage   89.30%   89.31%           
=======================================
  Files         185      185           
  Lines        5593     5597    +4     
  Branches     1325     1330    +5     
=======================================
+ Hits         4995     4999    +4     
  Misses        590      590           
  Partials        8        8           
Impacted Files Coverage Δ
src/workbench/menuBar/horizontalView.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c776c7...c3a2048. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 2294b3d into main Feb 11, 2022
@wewoor wewoor deleted the fix/menuBarInteraction branch February 11, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants