Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support listen to the theme changed event #646

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Conversation

kiwiwong
Copy link
Collaborator

@kiwiwong kiwiwong commented Feb 8, 2022

Description

Support listen to the theme changed event.

Fixes #645

Changes

  • ColorThemeService extends GlobalEvent
  • Added onChange method to ColorThemeService

@kiwiwong kiwiwong self-assigned this Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #646 (a00e79a) into main (1c776c7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
+ Coverage   89.30%   89.31%   +0.01%     
==========================================
  Files         185      185              
  Lines        5593     5599       +6     
  Branches     1325     1325              
==========================================
+ Hits         4995     5001       +6     
  Misses        590      590              
  Partials        8        8              
Impacted Files Coverage Δ
src/services/theme/colorThemeService.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c776c7...a00e79a. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 2590217 into main Feb 10, 2022
@wewoor wewoor deleted the feat/themeOnChange branch February 10, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support listen to the theme changed event
2 participants