Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not allowed to reload the initialize method #580

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Dec 29, 2021

Description

Disable to reload the initialize method of MoleculeProvider when triggering the Componen hot reload.

Fixes #579

Changes

  • Add loaded flag in ExtensionService
  • Not allowed to load the initialize if the ExtensionService is loaded
  • Add unit tests for loaded logic

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #580 (aa45b7f) into main (d20d104) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   87.27%   87.28%   +0.01%     
==========================================
  Files         190      190              
  Lines        5571     5578       +7     
  Branches     1241     1243       +2     
==========================================
+ Hits         4862     4869       +7     
  Misses        699      699              
  Partials       10       10              
Impacted Files Coverage Δ
src/provider/molecule.tsx 100.00% <100.00%> (ø)
src/services/extensionService.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20d104...aa45b7f. Read the comment docs.

@wewoor wewoor self-assigned this Dec 29, 2021
@wewoor wewoor added this to the 0.9.0-beta.2 milestone Dec 29, 2021
@wewoor wewoor mentioned this pull request Dec 29, 2021
11 tasks
Copy link
Collaborator

@kiwiwong kiwiwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 7229fc5 into main Dec 30, 2021
@wewoor wewoor deleted the fix/extReload branch December 30, 2021 08:02
@wewoor wewoor mentioned this pull request Jan 7, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用中遇到的一些问题汇总
3 participants