Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support a new Welcome page #508

Merged
merged 5 commits into from
Nov 17, 2021
Merged

feat: support a new Welcome page #508

merged 5 commits into from
Nov 17, 2021

Conversation

mortalYoung
Copy link
Collaborator

@mortalYoung mortalYoung commented Nov 11, 2021

简介

  • 优化 Welcome 页面
  • 移除 StoryBook 的自定义首页

Resolved #349

@mortalYoung mortalYoung self-assigned this Nov 11, 2021
@mortalYoung mortalYoung added the enhancement New feature or request label Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #508 (2429e1d) into main (00e8f7b) will decrease coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   85.67%   85.64%   -0.03%     
==========================================
  Files         180      182       +2     
  Lines        5290     5308      +18     
  Branches     1185     1186       +1     
==========================================
+ Hits         4532     4546      +14     
- Misses        751      755       +4     
  Partials        7        7              
Impacted Files Coverage Δ
src/workbench/editor/welcome/index.tsx 60.00% <33.33%> (-40.00%) ⬇️
src/workbench/editor/welcome/hooks.ts 84.61% <84.61%> (ø)
src/workbench/editor/welcome/logo.tsx 100.00% <100.00%> (ø)
src/molecule.api.ts 100.00% <0.00%> (ø)
src/services/theme/colorThemeService.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e8f7b...2429e1d. Read the comment docs.

@wewoor
Copy link
Collaborator

wewoor commented Nov 12, 2021

image

@mortalYoung 这个测试 Case 在一定条件下就会失败

@mortalYoung
Copy link
Collaborator Author

image

@mortalYoung 这个测试 Case 在一定条件下就会失败

什么条件下会失败,有复现的过程吗

@wewoor
Copy link
Collaborator

wewoor commented Nov 15, 2021

image
@mortalYoung 这个测试 Case 在一定条件下就会失败

什么条件下会失败,有复现的过程吗

感觉是不是异步的问题,因为之前 main 分支经常失败,重跑就好

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit e5e0a0c into main Nov 17, 2021
@wewoor wewoor deleted the feat/welcome branch November 17, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReDesign the default page of Workbench
2 participants